Follow-up: Workaround for libmp4v2 2.0.0 #969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
http://linux.die.net/man/3/mp4gettrackmaxsamplesize Return values: Upon success, the maximum sample size in bytes. Upon an error, 0.
uklotzde
changed the title
| @@ -40,6 +40,16 @@ const SINT kNumberOfPrefetchFrames = 2112; | |||
| // The TrackId is a 1-based index of the tracks in an MP4 file | |||
| const u_int32_t kMinTrackId = 1; | |||
|
|
|||
| // According to various references DecoderConfigDescriptor.bufferSizeDB | |||
| // is a 24-bit unsigned integer value. | |||
There was a problem hiding this comment.
OK, the yes data field is able to store 24 bit. That means up to 16 MB buffer for one SampleBlock.
That sounds incredible high. The SampleBlock size from real files is always below 1 KB.
I was hoping we where able to reduce the maximum buffer even more.
How could one design a portable mp4 player if it need to provide up to 16 MB RAM.
But why is the field 24 bit though ... :-/
|
Thank you, for the real good improvements. LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some improvements and additional documentation as a follow up for Daniel's bug report and fix:
https://bugs.launchpad.net/mixxx/+bug/1594169