Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance precision of track duration #970

Merged
merged 10 commits into from
Jun 25, 2016
Merged

Enhance precision of track duration #970

merged 10 commits into from
Jun 25, 2016

Commits on Jun 25, 2016

  1. Move formatting of durations from Time into Duration class

    @uklotzde
    uklotzde committed Jun 25, 2016
    Configuration menu
    Copy the full SHA
    4e82485 View commit details
    Browse the repository at this point in the history

  2. Calculate duration (in seconds) as double value in AudioSource

    @uklotzde
    uklotzde committed Jun 25, 2016
    Configuration menu
    Copy the full SHA
    b0debc7 View commit details
    Browse the repository at this point in the history

  3. Enhance precision of track duration from int to double

    @uklotzde
    uklotzde committed Jun 25, 2016
    Configuration menu
    Copy the full SHA
    8ce8f1f View commit details
    Browse the repository at this point in the history

  4. Read track duration with millisecond precision from TagLib 

    Requires TagLib v1.10 or newer.
    @uklotzde
    uklotzde committed Jun 25, 2016
    Configuration menu
    Copy the full SHA
    1d8d933 View commit details
    Browse the repository at this point in the history

  5. Fix build for older versions of TagLib before 1.10 

    Ubuntu 14.04 only provides TagLib 1.9.x
    @uklotzde
    uklotzde committed Jun 25, 2016
    Configuration menu
    Copy the full SHA
    db2e002 View commit details
    Browse the repository at this point in the history

  6. Use integer divisor

    @uklotzde
    uklotzde committed Jun 25, 2016
    Configuration menu
    Copy the full SHA
    99f990a View commit details
    Browse the repository at this point in the history

  7. Remove obsolete cast to double

    @uklotzde
    uklotzde committed Jun 25, 2016
    Configuration menu
    Copy the full SHA
    c160ca9 View commit details
    Browse the repository at this point in the history

  8. Replace magic number with constant

    @uklotzde
    uklotzde committed Jun 25, 2016
    Configuration menu
    Copy the full SHA
    86c9a63 View commit details
    Browse the repository at this point in the history

  9. Revert DB schema update and reuse existing duration column 

    For newly created DB files use the correct type for the schema.
Existing DB files are backwards compatible according to the
documentation:

https://www.sqlite.org/datatype3.html
"Any column in an SQLite version 3 database, except an INTEGER PRIMARY KEY
column, may be used to store a value of any storage class."
    @uklotzde
    uklotzde committed Jun 25, 2016
    Configuration menu
    Copy the full SHA
    b762633 View commit details
    Browse the repository at this point in the history

  10. Fix a leftover from the previous revert commit

    @uklotzde
    uklotzde committed Jun 25, 2016
    Configuration menu
    Copy the full SHA
    1070a48 View commit details
    Browse the repository at this point in the history