Cue colors

[ferranpujolcamins]

This is the first step of https://blueprints.launchpad.net/mixxx/+spec/cuepoints-2.0-new
I'll be issuing small PR regularly, instead of a big messy one.

Here I prepare the database and the DAO layer to support cue colors. I also make waveformrendermark to draw the mark according to the cue color. It also draws cue label.

[uklotzde]

Should be enclosed in an anonymous namespace to restrict the visibility of this symbol. Otherwise it is visible globally and might cause conflicts during linking.

[uklotzde]

I would use QColor instead of QString for this constant.

[daschuer]

By the way: Thank you very much for adopting this big topic.

[ferranpujolcamins]

Everything's fixed :)

[uklotzde]

Just a minor naming issue: Should be pMark in both this declaration and the definition in the .cpp file.

[uklotzde]

Thank you very much, Ferran!

I did not have the time to test your extensions, maybe sometime during the following days ;)

[daschuer]

Travis fails:

Failed query: "ALTER TABLE cues ADD COLUMN color INTEGER DEFAULT 0xFFFF0000 NOT NULL" QSqlError(1, "Unable to execute statement", "unrecognized token: "0xFFFF0000"")

[uklotzde]

As I mentioned, hexadecimal integers are supported since SQLite 4.8.6
according to the documentation, but on Travis we are using
4.8.5-some-ubuntu-patchlevel for Linux and ??? for OS X.

I thought this was already fixed?

On 21.08.2016 22:23, Daniel Schürmann wrote:

Travis fails:

Failed query: "ALTER TABLE cues ADD COLUMN color INTEGER DEFAULT
0xFFFF0000 NOT NULL" QSqlError(1, "Unable to execute statement",
"unrecognized token: "0xFFFF0000"")

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#992 (comment), or
mute the thread
https://github.com/notifications/unsubscribe-auth/ABZ-ahUEBJd2nf_Gs4B38uiI8a0GB3Q7ks5qiLPXgaJpZM4Jj7vm.

[ferranpujolcamins]

Sorry, I forgot about that. It is fixed now. Thank your for the review and explanations, I really appreciate it!

Next thing to come is a new combobox to select colors :)

[ferranpujolcamins]

A comment would be nice, what this "random" number is.

Done

[ferranpujolcamins]

@daschuer @uklotzde please merge this if there's nothing more to be done. I don't want more stale PR that need to be reviewed again in six months.

[uklotzde]

I don't have write permissions ;)

On 27.08.2016 12:39, Ferran Pujol Camins wrote:

@daschuer https://github.com/daschuer @uklotzde
https://github.com/uklotzde please merge this if there's nothing more to
be done. I don't want more stale PR that need to be reviewed again in six
months.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#992 (comment), or
mute the thread
https://github.com/notifications/unsubscribe-auth/ABZ-agHGE9tAmwlG-7vQku5srDG8NseOks5qkBPhgaJpZM4Jj7vm.

[daschuer]

Thank you very much for this nice first step! :-)

[ferranpujolcamins]

Thank you for your support :)