[qt5-base] fix linking of SQLite in vcpkg-cmake-wrapper.cmake #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FindSQLite3.cmake included in CMake exports a SQLite::SQLite3 target: https://cmake.org/cmake/help/latest/module/FindSQLite3.html
|
I am puzzled how this worked before. |
Be-ing
added a commit
to mixxxdj/mixxx
that referenced
this pull request
Oct 16, 2021
This is required to work with mixxxdj/vcpkg#27
Be-ing
added a commit
to Be-ing/mixxx
that referenced
this pull request
Oct 17, 2021
This is required to work with mixxxdj/vcpkg#27
Be-ing
added a commit
to mixxxdj/mixxx
that referenced
this pull request
Oct 17, 2021
This is required to work with mixxxdj/vcpkg#27
Holzhaus
previously approved these changes
Oct 17, 2021
| @@ -22,7 +22,7 @@ if("${_target_type}" STREQUAL "STATIC_LIBRARY") | |||
| find_package(harfbuzz CONFIG) | |||
|
|
|||
| set_property(TARGET Qt5::Core APPEND PROPERTY INTERFACE_LINK_LIBRARIES | |||
| ZLIB::ZLIB JPEG::JPEG PNG::PNG Freetype::Freetype SQLite3::SQLite3 harfbuzz::harfbuzz | |||
| ZLIB::ZLIB JPEG::JPEG PNG::PNG Freetype::Freetype SQLite::SQLite3 harfbuzz::harfbuzz | |||
There was a problem hiding this comment.
Are you sure this is correct?
In Mixxx CMakeLists.txt, we also link to SQLite3::SQLite3...
There was a problem hiding this comment.
oops, accidently approved. SHould be a regular comment instead.
There was a problem hiding this comment.
This is changed in mixxxdj/mixxx#4432
Be-ing
added a commit
to mixxxdj/mixxx
that referenced
this pull request
Oct 19, 2021
This is required to work with mixxxdj/vcpkg#27
Be-ing
added a commit
to mixxxdj/mixxx
that referenced
this pull request
Oct 20, 2021
This is required to work with mixxxdj/vcpkg#27
Be-ing
added a commit
to mixxxdj/mixxx
that referenced
this pull request
Oct 24, 2021
This is required to work with mixxxdj/vcpkg#27
Be-ing
added a commit
to mixxxdj/mixxx
that referenced
this pull request
Oct 24, 2021
This is required to work with mixxxdj/vcpkg#27
Be-ing
added a commit
to mixxxdj/mixxx
that referenced
this pull request
Oct 26, 2021
This is required to work with mixxxdj/vcpkg#27
Be-ing
added a commit
to Be-ing/mixxx
that referenced
this pull request
Nov 10, 2021
This is required to work with mixxxdj/vcpkg#27
Be-ing
added a commit
to mixxxdj/mixxx
that referenced
this pull request
Nov 16, 2021
This is required to work with mixxxdj/vcpkg#27
Be-ing
added a commit
to mixxxdj/mixxx
that referenced
this pull request
Nov 17, 2021
This is required to work with mixxxdj/vcpkg#27
Be-ing
added a commit
to Be-ing/mixxx
that referenced
this pull request
Nov 17, 2021
This is required to work with mixxxdj/vcpkg#27
Be-ing
added a commit
to Be-ing/mixxx
that referenced
this pull request
Nov 20, 2021
This is required to work with mixxxdj/vcpkg#27
Be-ing
added a commit
to mixxxdj/mixxx
that referenced
this pull request
Nov 21, 2021
This is required to work with mixxxdj/vcpkg#27
Be-ing
added a commit
to mixxxdj/mixxx
that referenced
this pull request
Nov 21, 2021
This is required to work with mixxxdj/vcpkg#27
Be-ing
added a commit
to mixxxdj/mixxx
that referenced
this pull request
Nov 22, 2021
This is required to work with mixxxdj/vcpkg#27
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FindSQLite3.cmake included in CMake exports a SQLite::SQLite3
target:
https://cmake.org/cmake/help/latest/module/FindSQLite3.html