Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[qt5-base] fix linking of SQLite in vcpkg-cmake-wrapper.cmake #27

Merged
merged 1 commit into from
Oct 17, 2021
Merged

[qt5-base] fix linking of SQLite in vcpkg-cmake-wrapper.cmake #27

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion overlay/osx/qt5-base/vcpkg-cmake-wrapper.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ if("${_target_type}" STREQUAL "STATIC_LIBRARY")
find_package(harfbuzz CONFIG)

set_property(TARGET Qt5::Core APPEND PROPERTY INTERFACE_LINK_LIBRARIES
ZLIB::ZLIB JPEG::JPEG PNG::PNG Freetype::Freetype SQLite3::SQLite3 harfbuzz::harfbuzz
ZLIB::ZLIB JPEG::JPEG PNG::PNG Freetype::Freetype SQLite::SQLite3 harfbuzz::harfbuzz
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure this is correct?

In Mixxx CMakeLists.txt, we also link to SQLite3::SQLite3...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, accidently approved. SHould be a regular comment instead.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is changed in mixxxdj/mixxx#4432

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

double-conversion::double-conversion PostgreSQL::PostgreSQL OpenSSL::SSL OpenSSL::Crypto
)

Expand Down