Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feed.xml link tag uses a relative path, breaking RSS detection on some pages #195

Closed
oznogon opened this issue Jan 19, 2021 · 1 comment
Closed

Comments

@oznogon
Copy link

oznogon commented Jan 19, 2021

News articles are published to an Atom feed at https://mixxx.org/feed.xml, but in HTML across the site it links to a relative path:

    <link href="feed.xml" type="application/atom+xml" rel="alternate" title="Mixxx Atom Feed" />

This breaks RSS feed detection and links on, for instance, individual news articles because there's no feed.xml at https://mixxx.org/news/feed.xml.

Steps to reproduce:

  1. Go to mixxx.org or build the site locally and serve it.
  2. Go to any news article.
  3. View page source, or click the "Feed" link under "About" in the footer.

Expected behavior

The link or link tag points to /feed.xml.

Observed behavior

The link or link tag points to feed.xml, which results in a 404.

@Holzhaus
Copy link
Member

Should be fixed now, thanks for reporting.

deborahtrez pushed a commit to deborahtrez/website that referenced this issue Jan 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants