Migrate to MetaCPAN V1 API #520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miyagawa Do you have any concern on this? |
|
This looks good to me. |
|
one CI failure with 5.10.0 on build_no_mymeta.t but it's an error with MetaCPAN and was fixed upstream. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MetaCPAN API is now migrating from V0 to V1.
https://github.com/metacpan/metacpan-api/wiki/MetaCPAN-V1-announcement-and-migration-plan
And MetaCPAN V1 API introduces a new endpoint "download_url", which does almost the same things as Menlo::Index::MetaCPAN does.
https://github.com/metacpan/metacpan-api/blob/master/lib/MetaCPAN/Document/File/Set.pm#L187-L278
This pull request modifies Menlo::Index::MetaCPAN to use V1 "download_url" endpoint.