Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable GitHub Annotation for relative paths from non-repository root directory #2

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Enable GitHub Annotation for relative paths from non-repository root directory #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5d3cb0a
エラーを発生させてみる
mizdra Feb 18, 2023
58dbc17
reviewdog 使ってみる
mizdra Feb 18, 2023
c3cb455
lint-ci を用意する
mizdra Feb 18, 2023
fa10a98
lint と lint-ci を結合
mizdra Feb 18, 2023
7cc43b4
pipe-if-ci を使ってリファクタリング
mizdra Feb 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,5 +19,9 @@ jobs:
with:
node-version: 18
cache: 'npm'
- uses: reviewdog/action-setup@v1

- run: npm install
- run: npm run --workspaces lint
env:
REVIEWDOG_GITHUB_API_TOKEN: ${{ secrets.GITHUB_TOKEN }}
41 changes: 41 additions & 0 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
"@typescript-eslint/parser": "^5.52.0",
"eslint": "^8.34.0",
"npm-run-all": "^4.1.5",
"pipe-if-ci": "^0.0.1",
"typescript": "^4.9.5"
},
"workspaces": [
Expand Down
2 changes: 1 addition & 1 deletion packages/package-a/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"devDependencies": {},
"scripts": {
"lint": "run-s -c lint:*",
"lint:tsc": "tsc --noEmit",
"lint:tsc": "pipe-if-ci 'tsc --noEmit' -p 'reviewdog -f=tsc -reporter=github-check -fail-on-error'",
"lint:eslint": "eslint ."
},
"repository": {
Expand Down
2 changes: 1 addition & 1 deletion packages/package-a/src/index-package-a.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
// const a: string = 1
const a: string = 1

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success!

export {};
2 changes: 1 addition & 1 deletion packages/package-b/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"devDependencies": {},
"scripts": {
"lint": "run-s -c lint:*",
"lint:tsc": "tsc --noEmit",
"lint:tsc": "pipe-if-ci 'tsc --noEmit' -p 'reviewdog -f=tsc -reporter=github-check -fail-on-error'",
"lint:eslint": "eslint ."
},
"repository": {
Expand Down
2 changes: 1 addition & 1 deletion packages/package-b/src/index-package-b.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
// const a: string = 1
const a: string = 1

export {};