Merge pull request #36 from mizunashi-mana/partial-resolve-35

Partial resolve #35
mizunashi-mana · Nov 9, 2018 · 63b946d · 63b946d
2 parents ef699c0 + 12b1263
commit 63b946d
Show file tree

Hide file tree

Showing 6 changed files with 25 additions and 8 deletions.
diff --git a/src/DokuWiki/Plugin/Mdpage/MarkdownRendererTrait.php b/src/DokuWiki/Plugin/Mdpage/MarkdownRendererTrait.php
@@ -315,7 +315,7 @@ protected function renderLink($block) {
         $url = $block['url'];
         if (strpos($url, '/') === false) {
             $this->renderer->internallink($url, $this->collectText($block['text']));
-        } elseif (empty($block['title'])) {
+        } else { // title is not supported
             $this->renderer->externallink($url, $this->collectText($block['text']));
         }
 

diff --git a/tests/DokuWiki/Test/Plugin/Mdpage/MarkdownSpecTest.php b/tests/DokuWiki/Test/Plugin/Mdpage/MarkdownSpecTest.php
@@ -29,13 +29,6 @@ public function testFeatures() {
         );
     }
 
-    public function testIssue24() {
-        $this->assertSpec(
-            'issue-24/Content',
-            $this->defaultFlavors
-        );
-    }
-
     public function testHtmlok() {
         global $conf;
         $conf['htmlok'] = 1;
@@ -60,6 +53,20 @@ public function testCannotLookupRef() {
         );
     }
 
+    public function testIssue24() {
+        $this->assertSpec(
+            'issue-24/Content',
+            $this->defaultFlavors
+        );
+    }
+
+    public function testIssue35() {
+        $this->assertSpec(
+            'issue-35/Content',
+            $this->defaultFlavors
+        );
+    }
+
     /**
      * This plugin has fallback HTML rendering for PHP 7.2
      * So, the results of rendering are different between PHP >= 7.2 and PHP < 7.2.

diff --git a/tests/specs/issue-35/Content.md b/tests/specs/issue-35/Content.md
@@ -0,0 +1 @@
+[link](https://example.com "title")
diff --git a/tests/specs/issue-35/Content_GFM.html b/tests/specs/issue-35/Content_GFM.html
@@ -0,0 +1,3 @@
+<p>
+<a class="urlextern" href="https://example.com" rel="nofollow" title="https://example.com">link</a>
+</p>
diff --git a/tests/specs/issue-35/Content_MarkdownExtra.html b/tests/specs/issue-35/Content_MarkdownExtra.html
@@ -0,0 +1,3 @@
+<p>
+<a class="urlextern" href="https://example.com" rel="nofollow" title="https://example.com">link</a>
+</p>
diff --git a/tests/specs/issue-35/Content_Traditional.html b/tests/specs/issue-35/Content_Traditional.html
@@ -0,0 +1,3 @@
+<p>
+<a class="urlextern" href="https://example.com" rel="nofollow" title="https://example.com">link</a>
+</p>