Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Links with title broken #35

Closed
brzGatsu opened this issue Nov 9, 2018 · 3 comments · Fixed by #75
Closed

Links with title broken #35

brzGatsu opened this issue Nov 9, 2018 · 3 comments · Fixed by #75
Labels
bug Something isn't working good first issue Good for newcomers upstream issue Issue of depending external products

Comments

@brzGatsu
Copy link

brzGatsu commented Nov 9, 2018

DokuWiki 2018.04.22-0122
Apache 2.2.34-0020
PHP 7.0.30-0027

Links with title seem to be broken:

[I'm an inline-style link with title](https://www.google.com "Google's Homepage")

@mizunashi-mana mizunashi-mana added bug Something isn't working good first issue Good for newcomers labels Nov 9, 2018
@mizunashi-mana mizunashi-mana mentioned this issue Nov 9, 2018
2 tasks
mizunashi-mana added a commit that referenced this issue Nov 9, 2018
@mizunashi-mana mizunashi-mana reopened this Nov 9, 2018
@mizunashi-mana
Copy link
Owner

@brzGatsu Thanks for reporting! Partially, I fixed. You can see rendered link with titles on the latest release.

Sadly, link syntax of DokuWiki is not supported title. This plugin uses DokuWiki internal library as possible for maintenance costs. So, if DokuWiki is not supported a feature, this plugin cannot support it although Markdown is supported.
Now, we can use Markdown link syntax with title, but it is not rendered with correct title.

However, if many users of this plugin want it; especially add 👍 reaction on the top comment of this issue, I consider to add adhoc patch for DokuWiki internal library.

@mizunashi-mana mizunashi-mana added the upstream issue Issue of depending external products label Nov 9, 2018
@mizunashi-mana
Copy link
Owner

See also: dokuwiki/dokuwiki#2573

@mizunashi-mana
Copy link
Owner

Thanks for many voting. Now, this plugin supports links with titles. Please upgrade plugins.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers upstream issue Issue of depending external products
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants