Fix error loading browserchannel/BCSocket #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's not clear to me why Travis is failing. When I run the tests locally there are no issues. |
Closed
|
Thanks for your effort. Travis is always falling, locally they work and I have no idea why. I am currently looking at replacing sharejs with sharedb which would then also allow richt text editing. |
|
Brilliant, thanks! Replacing with ShareDB would be excellent. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately 0.10.1 contains a bug in loading BCSocket from the node module
browserchannelthatsharedepends on.I didn't spot it because I only tested my pull request as a local package in
<project>/packages. I've now tested this modification with a published package and it works correctly and fixes the issue.FYI 0.10.1 does not work at all as it is currently published.