Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recently realised that the
time_jitter
used in the time marginalisation for CBC signals inbilby
is actually a periodic parameter (see here). This prompted me to add a generic reparameterisation for parameters that aren't periodic on [0, pi] or [0, 2pi].The scale for generic periodic parameters is set as 2pi / angle_prior_range, for example for a parameter that is periodic on [-1, 1] the scale should be pi. This behaviour is enabled by setting
scale=None
.Bug fix
This PR also fixes a minor bug in all reparameterisations when
parameters=<some list>
: the list is not copied to changes to the parameters made in the reparameterisation will be reflect in the original list. This could lead to unexpected behaviour if that list is used in other parts of the code.