Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GW defaults #130

Merged
merged 2 commits into from
Nov 23, 2021
Merged

Update GW defaults #130

merged 2 commits into from
Nov 23, 2021

Conversation

mj-will
Copy link
Owner

@mj-will mj-will commented Nov 23, 2021

Update the default reparameterisations for a_1 and a_2 and add reparameterisations for: chi_1, chi_2, and time_jitter.

Reparameterisations

Validation

I've re-run the analysis from the paper with distance marginalisation enabled and seen roughly a 2x speed up whist still passing the P-P test:

image

@mj-will mj-will added the gw Changes to gravitational-wave related code label Nov 23, 2021
@mj-will mj-will added this to the v0.4.0 milestone Nov 23, 2021
@codecov-commenter
Copy link

codecov-commenter commented Nov 23, 2021

Codecov Report

Merging #130 (8d680ad) into main (9141aa9) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #130   +/-   ##
=======================================
  Coverage   95.04%   95.04%           
=======================================
  Files          39       39           
  Lines        3635     3635           
=======================================
  Hits         3455     3455           
  Misses        180      180           
Flag Coverage Δ
unittests 95.04% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
nessai/gw/proposal.py 84.37% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9141aa9...8d680ad. Read the comment docs.

@mj-will mj-will merged commit c98e24d into main Nov 23, 2021
@mj-will mj-will deleted the update-gw-defaults branch November 23, 2021 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gw Changes to gravitational-wave related code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants