Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the default reparameterisations for
a_1
anda_2
and add reparameterisations for:chi_1
,chi_2
, andtime_jitter
.Reparameterisations
a_1
anda_2
now usedefault
instead ofto-cartesian
chi_1
andchi_2
usedefault
time_jitter
uses the newperiodic
reparameterisation added in Add periodic reparameterisation #127Validation
I've re-run the analysis from the paper with distance marginalisation enabled and seen roughly a 2x speed up whist still passing the P-P test: