Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

State of the library #234

Closed
alex-dixon opened this issue Oct 12, 2017 · 9 comments
Closed

State of the library #234

alex-dixon opened this issue Oct 12, 2017 · 9 comments
Assignees

Comments

@alex-dixon
Copy link

Sorry to make an issue out of this, but I'm confused. I see expect has been donated to Facebook and future development will happen within Jest but I'm not clear on whether that means no maintenance or changes of any kind will happen in this repo and the npm package.

If not, could this repo to be maintained or developed separately for those of us who prefer it to Jest's version of expect?

@ljharb
Copy link
Sponsor Collaborator

ljharb commented Oct 12, 2017

I'd be happy to backport nonbreaking changes to v1, but I no longer have publish rights to expect.

@mjackson or @cpojer or the other folks here would have to be willing to do it, and I suspect none of them have interest in it.

If they'd be happy with me doing backports (using safe-publish-latest to ensure no "latest" mistakes), they're welcome to add me back as an owner on npm - but short of that, there's not likely to be any further development.

@ljharb ljharb closed this as completed Oct 12, 2017
@cpojer
Copy link

cpojer commented Oct 12, 2017

@ljharb added you back to the npm project :)

@ljharb
Copy link
Sponsor Collaborator

ljharb commented Oct 12, 2017

Thanks!

In that case, @alex-dixon: I'll update the readme, and ensure the appropriate protections are in place, and then I'll close this issue again - at which point, enhancements to v1 will be welcome.

@ljharb ljharb reopened this Oct 12, 2017
@alex-dixon
Copy link
Author

@ljharb Thanks! I think this is the best assertion library for Javascript and it seems like Jest has removed some of its features, like .toBeA. If I use the latest npm version, can I expect (har) all methods that are documented in the README?

@inca
Copy link

inca commented Nov 17, 2017

Same with .toExist — it's not a function anymore 😕

Since this module is used by so many people, can we please at least have some sort of public announcement with plans for future development?

@ljharb
Copy link
Sponsor Collaborator

ljharb commented Nov 18, 2017

@inca v21+ is part of jest; #234 (comment) is the announcement for further development here for versions < 21.

I haven't yet had time to update the readme, but when I do, I'll close this issue.

@alex-dixon
Copy link
Author

alex-dixon commented Nov 19, 2017

So npm install expect @ 0.20.0 should work for expect standalone?

Is there a way forward for development and maintenance? If so curious about the version scheme.

@ljharb
Copy link
Sponsor Collaborator

ljharb commented Nov 22, 2017

@alex-dixon v21+ is maintained by the jest team; I will continue to maintain v1. I'm unlikely to accept any breaking changes; I'm going to be very limited in the additive changes I expect; and I'm going to put tooling in place to ensure that I only ever publish pre-v21 versions under an npm tag that isn't "latest", so only people who have explicitly depended on pre-v21 versions see any further publishes (see #234 (comment))

@ljharb ljharb closed this as completed in 18a90de Nov 22, 2017
@mjackson
Copy link
Owner

Thanks for taking the baton here, @ljharb. I'm done maintaining my own assertion library! 😅

@ljharb ljharb self-assigned this Nov 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants