Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #38. move META file to fix tests when atdgen is not installed #57

Merged
merged 2 commits into from
Sep 15, 2016

Conversation

Khady
Copy link

@Khady Khady commented Sep 14, 2016

No description provided.

@mjambon
Copy link
Owner

mjambon commented Sep 14, 2016

I see that make test still works because it complains that it finds 2 meta files, but I don't know how. I can't find a reference explaining why META.something is treated like a META file and when. Could you please explain this as a comment in the file itself?

@Khady
Copy link
Author

Khady commented Sep 15, 2016

From http://projects.camlcity.org/projects/dl/findlib-1.6.2/doc/ref-html/r721.html

The outermost variable assignments and additions belong to the main package. The name of the main package is not defined within META; it is either the name of the directory containing META or the suffix of the META file (if the name of the META file is formed like META.name).

If this explanation is good for you, I will add it as a comment.

@mjambon
Copy link
Owner

mjambon commented Sep 15, 2016

Got it. Thank you!

@mjambon mjambon merged commit 0457e57 into mjambon:master Sep 15, 2016
@Khady Khady deleted the tests-fail-opam branch September 15, 2016 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants