Added input and action namespacing for formtastic 3.1 #116
Conversation
jkelleyj
commented
Jan 9, 2015
jkelleyj
commented
- cleanup on specs for previous input helper
- cleanup on specs for previous action helper
- upgrade rspec to 2.14 to sync with formtastic
- remove some deprecation warnings for rspec upgrade to 2.14
* cleanup on specs for previous input helper * cleanup on specs for previous action helper * upgrade rspec to 2.14 to sync with formtastic * remove some deprecation warnings for rspec upgrade to 2.14
|
@sodabrew here's a preliminary PR. I cleaned up some specs that were broken, but there are a nice chunk still busted that I don't have time to clear up right now. I started working on the select input because it seems to have some formtastic 3.1 issues now that grouped collections are out. I could use a little help there to make sure I'm not blasting away anything important. |
| rspec-expectations (2.99.2) | ||
| diff-lcs (>= 1.1.3, < 2.0) | ||
| rspec-mocks (2.99.2) | ||
| rspec-rails (2.99.0) |
There was a problem hiding this comment.
I'm not keen on the rspec 2.99 revisions - I think it's better to pin to rspec ~> 2.14.0 in this case.
There was a problem hiding this comment.
Will do, what's that main concern w/ 2.99?
There was a problem hiding this comment.
Running into an issue with the formtastic spec_helper still when pegging to ~> 2.14.0
uninitialized constant RSpec::Mocks::Double (NameError)
There was a problem hiding this comment.
Oh then it must be a new method in especially 3, that the 2.99 transitional package provides. So I'll take back my 2.14.0 suggestion :)
|
Nice work! I wrote up a bunch of inline comments, and then just saw that you addressed some of them already... about the namespaced finders. Could you take a look at #112 and advise if it impacts the functionality that @gbisheimer added? |
…GroupedCollection autoload * GroupedCollection was removed previously
|
Ok, this looks good. Are you ready for me to merge it or do you have some more changes in mind? |
|
Yeah, let's move ahead with this. Could you confirm that the tests are not any worse off from where you had them previously? I was counting 132 errors in the fresh cut and have it down to 118. I did remove a couple of specs where the functionality was now fully handled by Formtastic. I don't think that I broke any new specs, but honestly haven't dug into that. I'll put another commit on a separate PR for the select input GroupedCollections issue |
|
Awesome, here goes! |
Added input and action namespacing for formtastic 3.1
