Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to display some data from the query instead of match/no match image #3

Open
Commit-La-Grenouille opened this issue Apr 22, 2022 · 8 comments

Comments

@Commit-La-Grenouille
Copy link

Hi @mjbnz,

thank you very much for your plugin. It is the most flexible requests plugins for SD and the one that really embraces the SD spirit (actions and info). I was looking for something very similar but was hopping to use some data from the query as information to display on the key instead of just an image.

Would it be okay if I try to prepare a PR with this change ? Or would it not fit the vision your have for your plugin (and I should just fork it) ?

Based on the UI you have implemented, I think I would add a checkbox next to the "Set button image based on response" (i.e. "Return some data from response") and would present a similar field to determine what to search in the data.
Then on the code-side, I would try to plug it cleanly to the fetch call (like all the other option do) and do some additional code to either prepare the text and display it through a setTitle() or prepare the text and render it as image (like some other plugin do).

@Commit-La-Grenouille Commit-La-Grenouille changed the title Data from query display instead of match/no match image Display some data from the query instead of match/no match image Apr 22, 2022
@Commit-La-Grenouille Commit-La-Grenouille changed the title Display some data from the query instead of match/no match image Option to display some data from the query instead of match/no match image Apr 22, 2022
@mjbnz
Copy link
Owner

mjbnz commented Apr 23, 2022

Hi @Commit-La-Grenouille , in principle, yes, that sounds like a great feature. I'll happily look at a PR if you want to put one together.

Commit-La-Grenouille pushed a commit to Commit-La-Grenouille/streamdeck-api-request that referenced this issue Apr 24, 2022
Commit-La-Grenouille pushed a commit to Commit-La-Grenouille/streamdeck-api-request that referenced this issue Apr 24, 2022
…odate the showing data from response option
Commit-La-Grenouille added a commit to Commit-La-Grenouille/streamdeck-api-request that referenced this issue Apr 24, 2022
Commit-La-Grenouille added a commit to Commit-La-Grenouille/streamdeck-api-request that referenced this issue Apr 24, 2022
Commit-La-Grenouille added a commit to Commit-La-Grenouille/streamdeck-api-request that referenced this issue Apr 24, 2022
Commit-La-Grenouille added a commit to Commit-La-Grenouille/streamdeck-api-request that referenced this issue Apr 25, 2022
Commit-La-Grenouille added a commit to Commit-La-Grenouille/streamdeck-api-request that referenced this issue Apr 25, 2022
… and cabling it correctly in the code to keep all PI elements perfectly distinct in name
Commit-La-Grenouille added a commit to Commit-La-Grenouille/streamdeck-api-request that referenced this issue Jul 17, 2022
@annikovk
Copy link

annikovk commented Jan 4, 2023

Cool feature. Worth merging IMO

@MaxeoN
Copy link

MaxeoN commented Dec 24, 2023

Hi @Commit-La-Grenouille, with version 6.5.0 of the stream deck software data from responce doesn't work. Can you fix it, please?

@Commit-La-Grenouille
Copy link
Author

Commit-La-Grenouille commented Dec 25, 2023 via email

@MaxeoN
Copy link

MaxeoN commented Dec 25, 2023

Thank's for your feedback @Commit-La-Grenouille. There is no any log file created by the plugin in the specified folder "%appdata%\Elgato\StreamDeck\logs". Should i turn it on somwhere in the plugin script?
I have found the problem, it's all about backgroung image. That should be set anyway or title won't show anything.
Is that possible to add more than one string? For e.g. i have a device that can send me temperature, humidity and pressure. I want to add all of these strings to the button. Is that realizable?

@Commit-La-Grenouille
Copy link
Author

Commit-La-Grenouille commented Dec 26, 2023 via email

@MaxeoN
Copy link

MaxeoN commented Dec 26, 2023

I have found the problem, it's all about backgroung image. That should be set anyway or title won't show anything.
Is that possible to add more than one string? For e.g. i have a device that can send me temperature, humidity and pressure. I want to add all of these strings to the button. Is that realizable?

@Commit-La-Grenouille
Copy link
Author

Commit-La-Grenouille commented Dec 26, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants