This repository has been archived by the owner on Jan 26, 2022. It is now read-only.
Updating winget publish path (round 2) #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 4, 2021 22:05
ldennington
changed the title
mjcheetham
approved these changes
May 5, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Something that escaped me when I initially updated the winget manifest path (see this for reference) is that the new 1.0 format requires manifests to be located at:
manifests/<first_letter_of_organization_name>/<organization_name>/<package_name/<version>/<organization_name>.<package_name>.ymlinstead of
manifests/<first_letter_of_organization_name>/<organization_name>/<package_name/<version>.ymlThis feels long and silly, but I had no say in the matter, so I'm making the appropriate fix in our code.
Tested by running my validation action which published a PR containing a manifest at the correct path in my winget-playground repo.