Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

29 new dashboard #30

Merged
merged 7 commits into from
Feb 8, 2024
Merged

29 new dashboard #30

merged 7 commits into from
Feb 8, 2024

Conversation

dgscwhite
Copy link
Collaborator

User story complete.
New dashboard in streamlit with:

  • The full master_log table.
  • A bar chart showing launches by aircraft commander sorted from highest to lowest
  • A refresh data button (untested)
  • The ability to filter the table by Aircraft Commander
  • A dummy page called GIF Tracker to demonstrate the possiblity of having further subpages

@dgscwhite dgscwhite added the enhancement New feature or request label Feb 6, 2024
@dgscwhite dgscwhite self-assigned this Feb 6, 2024
@dgscwhite dgscwhite linked an issue Feb 6, 2024 that may be closed by this pull request
4 tasks
Copy link
Owner

@mjennings061 mjennings061 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work @dgscwhite. All in two days having never used streamlit or git before 💪
I have added some suggestions and comments. Could you please make the changes I have suggested, or leave further comments. Once complete, fire me a message and I can resolve any open comments.
I will create separate issues for the following:

  • Connect to the db in a function so we don't have reused code or exposed secrets
  • Update the DB password since its in the git history here. I will let you know this
  • To add more graphs

src/dashboard/requirements.txt Outdated Show resolved Hide resolved
src/dashboard/dashboard.py Outdated Show resolved Hide resolved
src/dashboard/dashboard.py Outdated Show resolved Hide resolved
src/dashboard/dashboard.py Outdated Show resolved Hide resolved
src/dashboard/dashboard.py Outdated Show resolved Hide resolved
src/dashboard/dashboard.py Outdated Show resolved Hide resolved
src/dashboard/dashboard.py Outdated Show resolved Hide resolved
src/dashboard/pages/gif_tracker.py Outdated Show resolved Hide resolved
src/dashboard/dashboard.py Outdated Show resolved Hide resolved
src/dashboard/dashboard.py Outdated Show resolved Hide resolved
@dgscwhite
Copy link
Collaborator Author

@mjennings061 many thanks for the positive feedback. All changes made and committed for review.

@dgscwhite
Copy link
Collaborator Author

@mjennings061 all done

Copy link
Owner

@mjennings061 mjennings061 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks snazzy. I have tried it on my machine and seems to work. Look at these column values 😍 :

image

src/dashboard/dashboard.py Show resolved Hide resolved
src/dashboard/dashboard.py Outdated Show resolved Hide resolved
src/dashboard/dashboard.py Outdated Show resolved Hide resolved
src/dashboard/dashboard.py Outdated Show resolved Hide resolved
src/dashboard/dashboard.py Show resolved Hide resolved
src/dashboard/dashboard.py Outdated Show resolved Hide resolved
src/dashboard/dashboard.py Outdated Show resolved Hide resolved
src/dashboard/dashboard.py Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
@dgscwhite
Copy link
Collaborator Author

@mjennings061

@dgscwhite dgscwhite merged commit 3ce42d1 into main Feb 8, 2024
@dgscwhite dgscwhite deleted the 29-new-dashboard branch February 8, 2024 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

Successfully merging this pull request may close these issues.

New Dashboard
2 participants