White Light Bulb LB1 (0x60c7) support #341
Conversation
…me and cloud params" This reverts commit bd1e89b.
… added" This reverts commit 936aa47.
| def set_power(self, state): | ||
| self.set_brightness(100) | ||
| self.set_state(state) |
There was a problem hiding this comment.
I don't think this method is necessary.
There was a problem hiding this comment.
I wrote this as a hook to broadlink_cli . Am I wrong?
There was a problem hiding this comment.
This class needs a rework. set_state() should be renamed to set_power(). And the new set_state() should get a dictionary as input. I intend to rework this class when I find some time, but I am working on a lot of things, so feel free to address this issue if you want to. I think we need a better interface for this class.
Ah, we don't want to send two packets with the same function. Our communication must be atomic, so client applications can handle exceptions.
| def check_power(self): | ||
| return self.get_state() |
There was a problem hiding this comment.
The same for this one. Why a method just to call another method that already exists?
There was a problem hiding this comment.
I wrote this as a hook to broadlink_cli . Am I wrong?
| def set_brightness(self, state): | ||
| cmd = '{"brightness":%d}' % state | ||
| self.send_command(cmd) |
There was a problem hiding this comment.
This is good. We definitely need this method.
|
This class was refactored. Now we use set_state() and get_state() to control the attributes. We can adapt the CLI in the future. Thank you! |
White Light Bulb LB1 (0x60c7) support