Skip to content

Commit

Permalink
- Solved some name conflicts that would break installation in Mautic …
Browse files Browse the repository at this point in the history
…2.10.1

- Changed use statement that would cause an error when CampaignSubscriber class would be called
- Chabged SmsEvent parameter declaration in onPostSave event. This were causing warning being raised due tonamespace confusion
  • Loading branch information
andre.rocha committed Sep 25, 2017
1 parent dad76df commit ef8e7aa
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 13 deletions.
22 changes: 11 additions & 11 deletions Config/config.php
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
return [
'services' => [
'events' => [
'mautic.sms.campaignbundle.subscriber' => [
'mautic.sms.infobipcampaignbundle.subscriber' => [
'class' => 'MauticPlugin\MauticInfoBipSmsBundle\EventListener\CampaignSubscriber',
'arguments' => [
'mautic.helper.integration',
Expand All @@ -28,47 +28,47 @@
'mautic.asset.helper.token',
],
],
'mautic.sms.channel.subscriber' => [
'mautic.sms.infobipchannel.subscriber' => [
'class' => \MauticPlugin\MauticInfoBipSmsBundle\EventListener\ChannelSubscriber::class,
'arguments' => [
'mautic.helper.integration',
],
],
'mautic.sms.message_queue.subscriber' => [
'mautic.sms.infobipmessage_queue.subscriber' => [
'class' => \MauticPlugin\MauticInfoBipSmsBundle\EventListener\MessageQueueSubscriber::class,
'arguments' => [
'mautic.sms.model.sms',
],
],
'mautic.sms.stats.subscriber' => [
'mautic.sms.infobipstats.subscriber' => [
'class' => \MauticPlugin\MauticInfoBipSmsBundle\EventListener\StatsSubscriber::class,
'arguments' => [
'doctrine.orm.entity_manager',
],
],
],
'forms' => [
'mautic.form.type.sms' => [
'mautic.form.type.infobipsms' => [
'class' => 'MauticPlugin\MauticInfoBipSmsBundle\Form\Type\SmsType',
'arguments' => 'mautic.factory',
'alias' => 'sms',
],
'mautic.form.type.smsconfig' => [
'mautic.form.type.infobipsmsconfig' => [
'class' => 'MauticPlugin\MauticInfoBipSmsBundle\Form\Type\ConfigType',
'alias' => 'smsconfig',
],
'mautic.form.type.smssend_list' => [
'mautic.form.type.infobipsmssend_list' => [
'class' => 'MauticPlugin\MauticInfoBipSmsBundle\Form\Type\SmsSendType',
'arguments' => 'router',
'alias' => 'smssend_list',
],
'mautic.form.type.sms_list' => [
'mautic.form.type.infobipsms_list' => [
'class' => 'MauticPlugin\MauticInfoBipSmsBundle\Form\Type\SmsListType',
'alias' => 'sms_list',
],
],
'helpers' => [
'mautic.helper.sms' => [
'mautic.helper.infobipsms' => [
'class' => 'MauticPlugin\MauticInfoBipSmsBundle\Helper\SmsHelper',
'arguments' => [
'doctrine.orm.entity_manager',
Expand All @@ -81,7 +81,7 @@
],
],
'other' => [
'mautic.sms.api' => [
'mautic.infobipsms.api' => [
'class' => 'MauticPlugin\MauticInfoBipSmsBundle\Api\InfoBipApi',
'arguments' => [
'mautic.page.model.trackable',
Expand All @@ -93,7 +93,7 @@
],
],
'models' => [
'mautic.sms.model.sms' => [
'mautic.infobipsms.model.sms' => [
'class' => 'MauticPlugin\MauticInfoBipSmsBundle\Model\SmsModel',
'arguments' => [
'mautic.page.model.trackable',
Expand Down
2 changes: 1 addition & 1 deletion EventListener/CampaignSubscriber.php
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
use Mautic\CampaignBundle\Event\CampaignExecutionEvent;
use Mautic\CoreBundle\EventListener\CommonSubscriber;
use Mautic\PluginBundle\Helper\IntegrationHelper;
use MauticPlugin\MauticInfoBipSmsBundle\Model\SmsModel;
use Mautic\SmsBundle\Model\SmsModel;
use MauticPlugin\MauticInfoBipSmsBundle\SmsEvents;

/**
Expand Down
2 changes: 1 addition & 1 deletion EventListener/SmsSubscriber.php
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ public static function getSubscribedEvents()
*
* @param SmsEvent $event
*/
public function onPostSave(\MauticPlugin\MauticInfoBipSmsBundle\Event\SmsEvent $event)
public function onPostSave(SmsEvent $event)
{
$entity = $event->getSms();
if ($details = $event->getChanges()) {
Expand Down

0 comments on commit ef8e7aa

Please sign in to comment.