Update black-friday.mjml. Port to V4 #12
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-Ported to MJML V4
-Removed MOST in-line sytles and moved to attributes and classes.
Many of the in-line styles throwed illegal attribute errors.
-Tried to comment as clear and concise as possible for newcomers.
Other Comments:
-Line number fourfolds but markup is cleaner.
-Didn't remove inline style @176
<mj-button><span style="color:#212020">Shop Now</span></mj-button>
Because
1.- for didactical purposes (IMHO templates are very good hands-on tutorial for beginners and might be somewhat better than documentation itself)
2.- For some others creating a class for just one style might be an overkill
Edited and validated using Windows Desktop App
MJML App V3.0.2
MKMK v^4.6.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was done
Ported to MJML V4
Removed MOST in-line sytles and moved to attributes and classes.
Many of the in-line styles throwed illegal attribute errors.
Tried to comment as clear and concise as possible for newcomers.
Other Comments:
<mj-button><span style="color:#212020">Shop Now</span></mj-button>Environment
Edited and validated using Windows Desktop App
MJML App V3.0.2
MKMK v^4.6.2