Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow renaming of MJML file #270

Closed
n1ckc1n opened this issue Oct 30, 2018 · 5 comments
Closed

Allow renaming of MJML file #270

n1ckc1n opened this issue Oct 30, 2018 · 5 comments

Comments

@n1ckc1n
Copy link

n1ckc1n commented Oct 30, 2018

Is there any way to rename the mjml files without losing the preview in the app home screen? It seems to only show the preview if the mjml file is named index.

image

@torncheesecake
Copy link

Works fine for me on version 2.10.0

@n1ckc1n
Copy link
Author

n1ckc1n commented Feb 6, 2019

I'm on the latest version and it doesn't work for me.

Steps to reproduce:

  1. Create a new project
  2. Close MJML App
  3. Browse to project folder on computer
  4. Rename index.mjml to something else
  5. Double click to open the newly named file
  6. Click back to go to menu screen
  7. Thumbnail is now the generic envelope image

@MateuszDabrowski
Copy link
Contributor

It might be a stupid question, but I saw many people doing this mistake - are you adding .mjml on the end of the new name? Without it app won't recognize the file and the outcome will be exactly like the one you show.

@n1ckc1n
Copy link
Author

n1ckc1n commented Feb 6, 2019

Thank you for your reply.

Yes, I'm on Windows 10 so extensions aren't included in the file names. Just to test I added the .mjml but still no thumbnail.

@kmcb777
Copy link
Contributor

kmcb777 commented May 22, 2019

@n1ckc1n I made a PR so that if there is no index.mjml in the project, it will look for any other mjml file in the project folder, and will use it for Preview. It should be ok for most use case.
Allowing to specify exactly which file you want to use as Preview would require some extra work on the menu, i'm not sure it's worth it

@iRyusa iRyusa closed this as completed in 5195f84 Jul 2, 2019
iRyusa added a commit that referenced this issue Jul 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants