Check for relative paths

[eikaramba]

As mentioned in #246, this idea is based on the fact that relative paths are normally not really supported in email clients(enlighten me if you think so. Maybe base64 encoded data, but the support ist quite bad). Thus, it might be nice to inform the user about this after exporting(i don't want to block the export action). This PR is WIP and open for discussion.

Works like this:

• Unfortunately you often have variables in your href or src like {{my_link}} which are meant to be replaced with a link in your backend system. This will be falsely detected as a relative path.
• The alert is now not going away automatically. i changed the alert api in order to support this.

[meriadec]

hey @eikaramba , thx for the PR, can you make it pass CI + update your code following feedbacks?

[eikaramba]

yes i will try my best :) sry first time using react and electron. I will try to adress all your issues

[eikaramba]

mhm somehow prettier command is failing, need to see another day what is causing that

[eikaramba]

added some form of tooltip for the description

[eikaramba]

is there anything that i can do to make this PR succeed? Or do you not know exactly whether this feature should be merged or not?

[iRyusa]

It's a bit late here... I'm sorry.

I would like to merge this into master @eikaramba can you just fix the conflict ?

[iRyusa]

Looks like you still have some issues with prettier, sorry about this, can you run it on listed file ?

[eikaramba]

yes i saw this, just hadn't had the time. will do this on the weekend

[eikaramba]

unfortunately both prettier and prettier:check run without any error on my pc. that is very strange, it seems there is nothing wrong here. travis does not include any clue what could be the problem.

[iRyusa]

Seems like those files have issues : $ prettier --list-different "{src,webpack}/**/*.js" src/components/FilesList/index.js src/components/ProjectsList/index.js src/helpers/sendEmail.js

…

On Fri, Jul 5, 2019 at 11:19 PM eikaramba ***@***.***> wrote: unfortunately both prettier and prettier:check run without any error on my pc. that is very strange, it seems there is nothing wrong here. travis does not include any clue what could be the problem. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#247?email_source=notifications&email_token=AAELHTOOKAVV5RQBRNHULATP563EPA5CNFSM4E7T5G32YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZKKNXY#issuecomment-508864223>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAELHTJAQ7AYWVSNMS75HLTP563EPANCNFSM4E7T5G3Q> .

[eikaramba]

i saw that, but unfortunately it runs fine locally and i don't see anything wrong with it, when i look manually into those files. i even tried to manually execute the prettiert command for all 3 files in VS Code but there was no change.

[meriadec]

updated. that's strange, maybe check the locally installed prettier version. on my side it's 1.18.2

LGTM thanks for the PR and sry for the delay 😅

[eikaramba]

will do, that is very strange. but thank you very much