Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allowed Attributes in mj-spacer differ from documentation #1102

Closed
justincolangelo opened this issue Mar 28, 2018 · 2 comments
Closed

Allowed Attributes in mj-spacer differ from documentation #1102

justincolangelo opened this issue Mar 28, 2018 · 2 comments
Milestone

Comments

@justincolangelo
Copy link

These options were commented out some time ago and then uncommented for validation reasons. I think they might be generic options that are used on other components and would need to be updated either in the documentation, the component script, or both.

static allowedAttributes = {
    'border': 'unit(px)',
    'border-bottom': 'unit(px)',
    'border-left': 'unit(px)',
    'border-radius': 'unit(px)',
    'border-right': 'unit(px)',
    'border-top': 'unit(px)',
    'container-background-color': 'color',
    'direction': 'enum(ltr,rtl)',
    'padding-bottom': 'unit(px,%)',
    'padding-left': 'unit(px,%)',
    'padding-right': 'unit(px,%)',
    'padding-top': 'unit(px,%)',
    'padding': 'unit(px,%){1,4}',
    'vertical-align': 'string',
    'width': 'unit(px,%)',
  }

height | px | spacer height | 20px
-- | -- | -- | --
css-class | string | class name, added to the root HTML element created | n/a


Reproduction Steps:

n/a

Expected behavior:

Documentation is up to date with code

Observed behavior:
n/a

MJML version:

latest

Email clients the bug is seen on:

n/a

@iRyusa
Copy link
Member

iRyusa commented Mar 29, 2018

Hi @justincolangelo

Some attributes are inherited from living inside mj-column but you're right they should be listed in the documentation

Thanks for finding this

@heyflo
Copy link

heyflo commented Apr 4, 2018

Hello!
When will the documentation be updated to match the current stable version (v4.x.x) ?

Thanks ✌️

@kmcb777 kmcb777 added this to the 4.1.0 milestone Apr 25, 2018
iRyusa added a commit that referenced this issue Apr 26, 2018
@iRyusa iRyusa closed this as completed in 0cd96a7 Apr 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants