Problem with usage in create-react-app application.

[siciarek]

I use mjml in my react app (create-react-app based).
Everything works fine when i use

"mjml": "^3.3.5",

After the upgrade to

"mjml": "^4.0.3",

Error occurs.

Error: Cannot find module "."

Steps to reproduce the error

$ create-react-app mjml-upgrade
$ cd mjml-upgrade
$ npm i -S mjml

in file index.js import mjml

import mjml2html from 'mjml'

run the app

$ nmp start

Error should occur.

[iRyusa]

Hi @siciarek

MJML4 wasn't really browser tested so build will most likely fail with webpack. Can you share the full stack of it so we can investigate if it's an easy fix ?

[siciarek]

webpackMissingModule
node_modules/uglify-js/tools/node.js:18
(anonymous function)
node_modules/uglify-js/tools/node.js:18
./node_modules/uglify-js/tools/node.js
node_modules/uglify-js/tools/node.js:17
__webpack_require__
/Users/siciarek/Workspace/mjml-upgrade/webpack/bootstrap ef69e669aec378bf1cbf:678
fn
/Users/siciarek/Workspace/mjml-upgrade/webpack/bootstrap ef69e669aec378bf1cbf:88
./node_modules/html-minifier/src/htmlminifier.js
node_modules/html-minifier/src/htmlminifier.js:8
__webpack_require__
/Users/siciarek/Workspace/mjml-upgrade/webpack/bootstrap ef69e669aec378bf1cbf:678
fn
/Users/siciarek/Workspace/mjml-upgrade/webpack/bootstrap ef69e669aec378bf1cbf:88
./node_modules/mjml-core/lib/index.js
node_modules/mjml-core/lib/index.js:61
__webpack_require__
/Users/siciarek/Workspace/mjml-upgrade/webpack/bootstrap ef69e669aec378bf1cbf:678
fn
/Users/siciarek/Workspace/mjml-upgrade/webpack/bootstrap ef69e669aec378bf1cbf:88
./node_modules/mjml/lib/index.js
node_modules/mjml/lib/index.js:7
__webpack_require__
/Users/siciarek/Workspace/mjml-upgrade/webpack/bootstrap ef69e669aec378bf1cbf:678
fn
/Users/siciarek/Workspace/mjml-upgrade/webpack/bootstrap ef69e669aec378bf1cbf:88
./src/index.js
http://localhost:3000/static/js/bundle.js:156239:63
__webpack_require__
/Users/siciarek/Workspace/mjml-upgrade/webpack/bootstrap ef69e669aec378bf1cbf:678
fn
/Users/siciarek/Workspace/mjml-upgrade/webpack/bootstrap ef69e669aec378bf1cbf:88
0
http://localhost:3000/static/js/bundle.js:156403:18
__webpack_require__
/Users/siciarek/Workspace/mjml-upgrade/webpack/bootstrap ef69e669aec378bf1cbf:678
./node_modules/ansi-regex/index.js.module.exports
/Users/siciarek/Workspace/mjml-upgrade/webpack/bootstrap ef69e669aec378bf1cbf:724
(anonymous function)
http://localhost:3000/static/js/bundle.js:728:10

[siciarek]

[iRyusa]

Looks like it doesn't like the require of html-minifier.

I'm not 100% that we can do something about it 🤔

[iRyusa]

As it's a dependency issue I don't think we can really do something about it yet, feel free to open a PR if you want to work on that, but browser build isn't in our test scope.

[mvfsillva]

Hi @siciarek, have you found any solutions to this problem?

[siciarek]

Hi, I am sorry, but I still have no solution. Creators told me, that they do not consider using their ap with webpack. I have frozen last working version ("^3.3.5") and keeping fingers crossed. Best, Jacek Siciarek wt., 16 lip 2019 o 18:38 Marcus Silva <notifications@github.com> napisał(a):

…

Hi @siciarek <https://github.com/siciarek>, have you found any solutions to this problem? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1108?email_source=notifications&email_token=AAAG2ALY3E25P4M2QO2DOWLP7X2OVA5CNFSM4EYGFAWKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2BN5WQ#issuecomment-511893210>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAAG2ANGZHLIK7EZX6A6BGLP7X2OVANCNFSM4EYGFAWA> .