Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The migration process replaces mj-includes with the actual content #1141

Closed
splitt3r opened this issue Apr 16, 2018 · 4 comments
Closed

The migration process replaces mj-includes with the actual content #1141

splitt3r opened this issue Apr 16, 2018 · 4 comments
Milestone

Comments

@splitt3r
Copy link

splitt3r commented Apr 16, 2018

Simple demo files from https://mjml.io/documentation/#mj-include.

Reproduction Steps:
The header.mjml file:

<mj-section>
  <mj-column>
    <mj-text>This is a header</mj-text>
  </mj-column>
</mj-section>

The index.mjml file:

<mjml>
  <mj-body>
    <mj-include path="header.mjml" />
  </mj-body>
</mjml>

Migrating the files via (PowerShell):
mjml -m .\index.mjml -o .\index.mjml

Observed behavior:
The index.mjml becomes:

<mjml>
  <mj-body>
    <mj-column>
      <mj-text>This is a header</mj-text>
    </mj-column>
  </mj-body>
</mjml>

MJML version:

4.0.3

Is there any way to force the correct behaviour of not replacing the include with its content?

@iRyusa
Copy link
Member

iRyusa commented Apr 18, 2018

Thanks for reporting this one @splitt3r !

Mhh, we might be able to add an option into the parser to skip include for 4.1 @kmcb777 ?

@iRyusa iRyusa added this to the 4.1.0 milestone Apr 18, 2018
@ngarnier ngarnier added this to Soon to be released in MJML Roadmap Apr 24, 2018
@brianespinosa
Copy link

Phew! I was going crazy trying to figure out what was going on trying to convert for v3 to v4. Glad to see there's already a PR open for this one.

kmcb777 added a commit that referenced this issue May 4, 2018
@kmcb777
Copy link
Collaborator

kmcb777 commented Jun 20, 2018

Hi @splitt3r @brianespinosa we released a new beta for mjml 4.1, which you can install with npm install mjml@next, could you check if it resolves this migration problem ?

@brianespinosa
Copy link

Thanks, @kmcb777

I will try to take a look early next week when I get a free cycle and report back.

@iRyusa iRyusa closed this as completed in b17d558 Jun 28, 2018
MJML Roadmap automation moved this from Soon to be released to Released Jun 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
MJML Roadmap
  
Released
Development

No branches or pull requests

4 participants