Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Since mjml 4.0.5 watch does not work #1171

Closed
vielhuber opened this issue Apr 26, 2018 · 9 comments
Closed

Since mjml 4.0.5 watch does not work #1171

vielhuber opened this issue Apr 26, 2018 · 9 comments
Milestone

Comments

@vielhuber
Copy link

index

@kmcb777
Copy link
Collaborator

kmcb777 commented Apr 26, 2018

Hi @vielhuber thanks for reporting this

@mohsentaleb
Copy link

I just tried 4.0.3 and 4.0.4 and they wont work either. Didn't have time to test previous versions.
@vielhuber @kmcb777

@kmcb777 kmcb777 added this to the 4.1.0 milestone Apr 26, 2018
@kmcb777
Copy link
Collaborator

kmcb777 commented Apr 26, 2018

Yes i saw that, but we hadn't noticed yet, anyway there's a pr for the fix now, should be included in 4.1 :)

@kukac7
Copy link
Contributor

kukac7 commented Apr 27, 2018

i have the same problem with me. (4.0.5)

@michelgotta
Copy link

michelgotta commented May 29, 2018

For everyone struggling with this and waiting for 4.1 to release. Here is a hotfix for 4.0.5 for usage like mjml --watch input.mjml --output index.html running it from node_modules and use a prebuild version:

In file node_modules/mjml-cli/lib/client.js find

if (inputs.length) {
    _context.next = 31;
    break;
}

error('No input files found');
return _context.abrupt('return');

replace lines 192–195 with:

if (true) {
    _context.next = 31;
    break;
}

or remove the if statement to pipe the code to the next step (31).

@kukac7 @mohsentaleb @vielhuber

@kmcb777
Copy link
Collaborator

kmcb777 commented Jun 20, 2018

Hi @michelgotta @kukac7 @mohsentaleb @vielhuber we released a new beta for mjml 4.1, which you can install with npm install mjml@next. This watch problem is now solved, feel free to try !

@iRyusa iRyusa closed this as completed in 8c6d306 Jun 28, 2018
@pierresis
Copy link

Hi @michelgotta @kukac7 @mohsentaleb @vielhuber we released a new beta for mjml 4.1, which you can install with npm install mjml@next. This watch problem is now solved, feel free to try !

It does not change anything for me :(

@kmcb777
Copy link
Collaborator

kmcb777 commented Mar 14, 2019

Hi @pierresis this bug is solved but maybe you have an other one, could you describe your problem a bit more ?
Which mjml version are you using ?
What command are you using ?
If you add --config.stack=true at the end of the command, do you get an error message ?

@pierresis
Copy link

Hi @kmcb777 this is ok, it was my bad. Dunno why i the version i had was before 4.0.
It's ok now :)

Thank you and have a good evening.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants