Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mjml-button: text-align not working #1188

Closed
zeitrechnen opened this issue May 9, 2018 · 2 comments
Closed

mjml-button: text-align not working #1188

zeitrechnen opened this issue May 9, 2018 · 2 comments
Labels
Milestone

Comments

@zeitrechnen
Copy link

Reproduction Steps:

  1. <mj-button href="https://www.example.com" text-align="left"><strong>Visist Website</strong></mj-button>

  2. Create HTML with mjml.

Expected behavior:

Text in button should be left aligned.

Observed behavior:

CLI output: (mj-button) — Attribute text-align is illegal

The attribute text-align is not defined in https://github.com/mjmlio/mjml/blob/master/packages/mjml-button/src/index.js as mentioned in the readme https://github.com/mjmlio/mjml/tree/master/packages/mjml-button.

MJML version:

mjml-core: 4.0.5
mjml-cli: 4.0.5

@iRyusa iRyusa added the Bug label May 14, 2018
@kmcb777 kmcb777 added this to the 4.2.0 milestone May 22, 2018
iRyusa added a commit that referenced this issue May 22, 2018
fix #1188 add text-align on mj-button
@kmcb777 kmcb777 modified the milestones: 4.2.0, 4.1.0 May 22, 2018
@kmcb777
Copy link
Collaborator

kmcb777 commented Jun 20, 2018

Hi @zeitrechnen we released a new beta for mjml 4.1, which you can install with npm install mjml@next, could you check if it resolves this problem ?

@zeitrechnen
Copy link
Author

@kmcb777 Problem is solved. Thank you!

@iRyusa iRyusa closed this as completed in df92c6e Jun 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants