Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Border-radius doesn't accept multiple values anymore #1653

Closed
MathieuLorber opened this issue Jul 24, 2019 · 2 comments
Closed

Border-radius doesn't accept multiple values anymore #1653

MathieuLorber opened this issue Jul 24, 2019 · 2 comments

Comments

@MathieuLorber
Copy link
Contributor

Since v4.4, a border-radius with multiple values (ie "10px 10px 0 0" for instance) raises an error when used on mj-column.

The error message :

(mj-column) — Attribute border-radius has invalid value: 0 0 20px 20px for type Unit, only accepts (px, %) units and 1 value(s)

  • still ok on mj-section though
  • was ok on 3.3.1

Observed with "standard" mjml to html function, on node, tested on macos/linux.

@iRyusa
Copy link
Member

iRyusa commented Jul 24, 2019

It should be easy to fix : adding a {1,4} here https://github.com/mjmlio/mjml/blob/master/packages/mjml-column/src/index.js#L11 should fix it.

Note that it's supported, and it's just a warning.

@MathieuLorber
Copy link
Contributor Author

Yeah sorry, it's just a warning.
=> I wrote the pull request #1654
Thank you !

kmcb777 added a commit that referenced this issue Jul 30, 2019
border-radius accepts multiple values (fix #1653)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants