Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mjml-boilerplate with 3.2.2 beta #492

Closed
Laslo89 opened this issue Jan 10, 2017 · 1 comment
Closed

mjml-boilerplate with 3.2.2 beta #492

Laslo89 opened this issue Jan 10, 2017 · 1 comment

Comments

@Laslo89
Copy link

Laslo89 commented Jan 10, 2017

is it possible to run the boilerplate with the latest beta version?

"mjml": "~3.2.0-beta.3",
"mjml-column": "~3.2.0-beta.2",
"mjml-core": "~3.2.0-beta.2",
"mjml-image": "~3.2.0-beta.2",
"mjml-section": "~3.2.0-beta.2",
"mjml-text": "~3.2.0-beta.2",

I added the latest version myself and modified a view things in the compile function inside the gulp file.
I added the --output param
I added error notification
see below:

const compile = () => {
  gulp.src('components/**.js')
    .pipe(babel())
    .pipe(gulp.dest('lib'))
    .on('end', () => exec(
      './node_modules/.bin/mjml index.mjml --output index.html',
      (err, stdout, stderr) => {
                // NOTE: logs errors of gulp (we think at least)
                if (err) {
                    console.log('ERROR:\n', err); // eslint-disable-line no-console
                }

                // NOTE: logs the error message of our own code
                if (stdout && stdout.trim()) {
                    console.log('CODE INFO:\n', stdout); // eslint-disable-line no-console
                }

                if (stderr) {
                    console.log('CODE ERROR:\n', stderr); // eslint-disable-line no-console
                }
            }
    ));
}

when i run npm run build i run into this error:

ERROR:
 { [Error: Command failed: /bin/sh -c node_modules/.bin/mjml index.mjml --output index.html
]
  killed: false,
  code: 1,
  signal: null,
  cmd: '/bin/sh -c node_modules/.bin/mjml index.mjml --output index.html' }
CODE INFO:
 Error: EISDIR: illegal operation on a directory, open './'
    at Error (native)

I saw some changes in the cli, which i think are causing that error, but i couldn't relate them exactly. Maybe the boilerplate has to adapt to the newer version?

@ngarnier
Copy link
Member

hey @Laslo89, I moved your issue here as it's related to the boilerplate and not MJML

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants