Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow css-class to add multiple class names via multiple mj-class #722

Closed
dermyhughes opened this issue Jun 15, 2017 · 1 comment
Closed

Comments

@dermyhughes
Copy link

dermyhughes commented Jun 15, 2017

Currently if you have css-class on amj-class and use multiple mj-class on a component, only the last css-class is actually added to the HTML.

I think it would be good if it would add all the classes.

Example:
Currently-

<mj-class name="foo" css-class="foo"..."
 <mj-class name="bar" css-class="bar"..."


<mj-text mj-class="foo bar"...

will only add the bar class to the HTML.

<tr class="bar">

Ideally it should add both classes:

<tr class="foo bar">

Thanks

@dermyhughes dermyhughes changed the title Allow css-class to add multiple class names Allow css-class to add multiple class names via multiple mj-class Jun 15, 2017
@iRyusa iRyusa added the MJML 4 label Jan 23, 2018
@iRyusa
Copy link
Member

iRyusa commented Jan 23, 2018

@kmcb777
I think this would nice to have for the release, and I don't think it would be hard to do with current mj-attributes implem ?

Can you take a look if we can have this for next beta too ?

@ngarnier ngarnier modified the milestones: 4.0.0, 4.1.0 Jan 25, 2018
@ngarnier ngarnier added this to Near Term in MJML Roadmap Feb 28, 2018
@ngarnier ngarnier moved this from Near Term to Soon to be released in MJML Roadmap Apr 25, 2018
kmcb777 added a commit that referenced this issue May 4, 2018
allow to cumulate css-classes from mj-classes - resolve #722
@iRyusa iRyusa closed this as completed in 4f11a20 Jun 28, 2018
MJML Roadmap automation moved this from Soon to be released to Released Jun 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
MJML Roadmap
  
Released
Development

No branches or pull requests

3 participants