Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature request]: Allow global lang attribute to be specified in template for accessibility #757

Closed
ghost opened this issue Jul 25, 2017 · 5 comments
Closed

[Feature request]: Allow global lang attribute to be specified in template for accessibility #757

ghost opened this issue Jul 25, 2017 · 5 comments
Labels
Feature request
Projects
MJML Roadmap
Milestone
4.1.0

Comments

@ghost
Copy link

ghost commented Jul 25, 2017

When creating MJML templates, there's currently no way to globally set the lang attribute, ie.

<html lang="de_DE">

The API returns the default locale value of "en_US". It would be useful if this could value could be set globally (in a way similar to the example below) instead of having to manually force this change post-compilation.

<mjml lang="de_DE">
@popzelife
Copy link

popzelife commented Jul 31, 2017 •
edited

Similar to #689 - Feature request to set lang globally in template

@iRyusa
Copy link
Member

iRyusa commented Aug 7, 2017

Hi @jwnip

Just for curiosity, what's the purpose of lang attributes in an email ?

@ghost
Copy link
Author

ghost commented Aug 7, 2017

@iRyusa It helps screen readers identify the pronunciation of words.

@iRyusa iRyusa changed the title [Feature request]: Allow global lang attribute to be specified in template [Feature request]: Allow global lang attribute to be specified in template for accessibility Aug 7, 2017
@iRyusa
Copy link
Member

iRyusa commented Aug 7, 2017

👍 Modifying the title then, we'll try to add it asap !

@ghost
Copy link
Author

ghost commented Aug 7, 2017

@iRyusa Excellent - thank you.

@ngarnier ngarnier added this to the 4.2.0 milestone Feb 28, 2018
@ngarnier ngarnier added this to Mid Term in MJML Roadmap Mar 13, 2018
@ngarnier ngarnier modified the milestones: 4.2.0, 4.1.0 Apr 24, 2018
kmcb777 added a commit that referenced this issue May 17, 2018
@kmcb777
Merge pull request #1167 from mjmlio/fix-757
63addab 
fix #757 add lang attribute
@iRyusa iRyusa closed this as completed in c700c56 Jun 28, 2018
MJML Roadmap automation moved this from Mid Term to Released Jun 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature request
Projects
No open projects
MJML Roadmap
  
Released
Milestone
4.1.0
Development

No branches or pull requests
3 participants
@iRyusa @ngarnier @popzelife