New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move js-beautify and html-minifier to cli #2059
Conversation
Ref mjmlio#1947 - minify outlook conditionals unconditionally like merging - moved js-beautify and html-minifier to cli - deprecated "minify" and "beautify" options in mjml-core
Looks good to me cc @ngarnier 5.X branch will remove those from core maybe we should discuss if we have more breaking changes to push in it ? |
Ok yeah @iRyusa let's chat this week |
We've just discussed about this @TrySound and we're ok to remove both of them in MJML5. However we still want to provide somekind of "easy" way to get them back. I think it could be done with
I'm not sure about the format tho, and if dynamic require would be an issue with browser build (webpack/rollup/...). Can we discuss about this together so we can ease the transition in MJML5 with proper doc on that ? |
I think we can provide custom plugins with hooks which run any minification or other tool. I can implement it in separate PR and default to it in cli. |
That would be so cool 👍 I'm merging this one as it's fine for MJML 4.8 then |
Will do this in a couple of weeks after vacation. |
@TrySound It seems like this will this break minification in the gulp tool. Is that true? |
Nope it wont the option will still be handled in core but display a warning during the transition. We'll just add those into gulp-mjml dependencies that's not that hard |
Or piped gulp plugins can be used instead to not bloat gulp-mjml and make it single purpose. |
Ref #1947