Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added role attribute to mj-tables #2303

Merged
merged 2 commits into from Jun 21, 2021
Merged

added role attribute to mj-tables #2303

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e5d2660
added role attribute to mj-table
mohamedsalem401 Jun 20, 2021
7fb1756
Add the role attribute to the MJ-table readme
mohamedsalem401 Jun 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/mjml-table/src/index.js
View file
Open in desktop
Expand Up @@ -24,6 +24,7 @@ export default class MjTable extends BodyComponent {
'padding-right': 'unit(px,%)',
'padding-top': 'unit(px,%)',
padding: 'unit(px,%){1,4}',
role: 'enum(none,presentation)',
iRyusa marked this conversation as resolved.
Show resolved Hide resolved
'table-layout': 'enum(auto,fixed,initial,inherit)',
'vertical-align': 'enum(top,bottom,middle)',
width: 'unit(px,%)',
Expand Down Expand Up @@ -66,7 +67,7 @@ export default class MjTable extends BodyComponent {

render() {
const tableAttributes = reduce(
['cellpadding', 'cellspacing'],
['cellpadding', 'cellspacing', 'role'],
(acc, v) => ({
...acc,
[v]: this.getAttribute(v),
Expand Down