carousel-URLs #2438
Merged
carousel-URLs #2438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Mar 2, @andyfoote reported documentation URLs that generated HTTP 404 errors. He reported them as the URLs identified as default values in the mj-carousel attributes table for attributes left-icon and right-icon.
His report is correct.
He further identified correct and corresponding URLs that don't get HTTP 404 errors. Those are in packages/mjml-carousel/src/Carousel.js and in object defaultAttributes.
The MJML team seeks to solve this with the correct URLs in the documentation.
This puts the correct URLs in packages/mjml-carousel/README.md.
No changes to other files. No changes to Javascript files.