improve mj-text doc #2492
Merged
improve mj-text doc #2492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iRyusa
reviewed
Jul 8, 2022
packages/mjml-text/README.md
Outdated
| @@ -19,7 +20,7 @@ This tag allows you to display text in your email. | |||
| ``` | |||
|
|
|||
| <p style="text-align: center;" > | |||
| <a href="https://mjml.io/try-it-live/components/text"> | |||
| <a href="https://mjml.io/try-it-live/E7Tk_8zjI"> | |||
There was a problem hiding this comment.
You don't need to change the link here it will fetch the content automatically 👍
iRyusa
reviewed
Jul 8, 2022
packages/mjml-text/README.md
Outdated
| @@ -1,16 +1,17 @@ | |||
| ## mj-text | |||
|
|
|||
| This tag allows you to display text in your email. | |||
| This tag allows you to display text and HTML in your email and has shorthand attributes for easily styling its children. | |||
There was a problem hiding this comment.
and has shorthand attributes for easily styling its children
Not sure this provide any value here. But 👍 to add HTML mentioned
There was a problem hiding this comment.
not sure what is the purpose of font-family="Helvetica" color="#F45E43" etc other than being shorthands
There was a problem hiding this comment.
I think this is self-explanatory, as you can say this for any component
iRyusa
approved these changes
Aug 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
from #1757