Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated lifecycle method in redirect.js #251

Closed
arananegra opened this issue Oct 25, 2019 · 7 comments
Closed

Deprecated lifecycle method in redirect.js #251

arananegra opened this issue Oct 25, 2019 · 7 comments

Comments

@arananegra
Copy link

Hi! In https://github.com/mjrussell/redux-auth-wrapper/blob/master/src/redirect.js there is a componentWillMount call which will be removed on next React versions. It will be great to update this file in order to make redux-auth-wrapper compatible with the upcoming React 17.x versions.

Thanks!

backend.js:6` Warning: componentWillMount has been renamed, and is not recommended for use. See https://fb.me/react-unsafe-component-lifecycles for details.

* Move code with side effects to componentDidMount, and set initial state in the constructor.
* Rename componentWillMount to UNSAFE_componentWillMount to suppress this warning in non-strict mode. In React 17.x, only the UNSAFE_ name will work. To rename all deprecated lifecycles to their new names, you can run `npx react-codemod rename-unsafe-lifecycles` in your project source folder.

Please update the following components: Redirect
@arananegra
Copy link
Author

Ups, I have just noticed that someone already push a pull request in order to deal with this problem #250

@davidkhierl
Copy link

up for this one

@pavolgolias
Copy link

Is there any progress in this issue? After some digging in my project I found out that this lib creates warnings for me too.

@arananegra
Copy link
Author

Is there any progress in this issue? After some digging in my project I found out that this lib creates warnings for me too.

I don't know if @mjrussell is still maintaining this library. As I said, @JackHowa submitted a pull request addressing this warning issue but it doesn't seem he is tracking it.

@pavolgolias
Copy link

Yes I see it now. Lets hope this lib is still maintained, I like this lib :)

@mjrussell
Copy link
Owner

Fixed in #250

@mjrussell
Copy link
Owner

I like this lib

Thanks 😄 sorry I haven't been the best maintainer...not doing much in React these days

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants