Add unsafe to component mount

[JackHowa]

Noticed a deprecation warning ahead of React 17. I've been working on trying to narrow down my project's warnings.

https://reactjs.org/blog/2018/03/27/update-on-async-rendering.html

[arananegra]

What about refactoring componentWillMount to componentDidMount?

[JackHowa]

I'm looking into tests as well for this. Wasn't sure since render will run after componentDidMount and saw the comment. It's could be a good refactor. https://github.com/mjrussell/redux-auth-wrapper/pull/250/files#diff-5f8ff02aeff466e04cfee5839e0f3bb7L16

  render() {
    // Redirect should happen before this is rendered
    return null
  }

[coveralls]

Coverage remained the same at 100.0% when pulling 95e9321 on JackHowa:unsafe-component-codemod into fecffb1 on mjrussell:master.

[coveralls]

Coverage remained the same at 100.0% when pulling 95e9321 on JackHowa:unsafe-component-codemod into fecffb1 on mjrussell:master.

[JackHowa]

what do you think @mjrussell ?

[JackHowa]

Let me know if you have any feedback @mjrussell. I'm trying to wrap up prs before the holidays so not nagging then

[pavolgolias]

Any progress on this? It would be great to fix compatibility for upcoming React 17.

[JackHowa]

I added the unsafe prefix there to maintain compatibility. Haven't heard from @mjrussell yet on this @pavolgolias

[mjrussell]

Sorry all, I've been really busy at work lately. I'll try to review this this weekend and get it in.

[pavolgolias]

Perfect, thanks in advance ;)

[JackHowa]

Just checking in on this @mjrussell. Sorry to be a bother

[mjrussell]

Not a bother! Sorry I clearly don't have enough time to maintain this repo well. Going to get this into a new release now

[mjrussell]

This ended up being a bit painful...I had to upgrade React, fix a lot of test deps and use a different library instead of react-router-redux.

Most of the changes are here - #257

But I haven't yet updated the examples or docs. This will be a new major release due to all the breaking changes

[mjrussell]

Just did the examples in #259. Once I do the docs I can cut a new version

[arananegra]

Thanks for addressing this. I really love this package and I really appreciate it!

[mjrussell]

Version 3.0.0 which was just released on npm includes this. Thanks everyone for your patience. Let me know if you run into any issues

[JackHowa]

Thanks for working on this @mjrussell