Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic example for react-router v4 #144

Closed
wants to merge 2 commits into from

Conversation

yurtaev
Copy link

@yurtaev yurtaev commented Apr 15, 2017

No description provided.

@coveralls
Copy link

coveralls commented Apr 15, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling e7fe532 on yurtaev:basic-example-rr-v4 into fd655d6 on mjrussell:rr-v4.

@yurtaev yurtaev changed the base branch from rr-v4 to rewrite-v2 May 3, 2017 17:05
import Admin from './Admin'
import Login from './Login'

module.exports = { App, Home, Foo, Admin, Login }
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be simplified:

export { default as App } from './App'
export { default as Home } from './Home'
export { default as Foo } from './Foo'
export { default as Admin } from './Admin'
export { default as Login } from './Login'

@mjrussell
Copy link
Owner

@yurtaev thank you for submitting this, Im sorry it kind of got lost in the churn of pulling stuff together for version 2.0. Theres an example for react router v4 now here - https://github.com/mjrussell/redux-auth-wrapper/tree/master/examples/react-router-4

Feel free to submit a follow up PR if you want to improve anything there

@mjrussell mjrussell closed this Jul 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants