Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add authenticatingSelector. #35

Merged
merged 9 commits into from May 3, 2016
Merged

Add authenticatingSelector. #35

merged 9 commits into from May 3, 2016

Conversation

cab
Copy link
Contributor

@cab cab commented May 3, 2016

Adds a selector (authenticatingSelector) to test if the user session is being loaded, and a LoadingComponent option to render during that time.

Fixes #30.

@coveralls
Copy link

coveralls commented May 3, 2016

Coverage Status

Coverage decreased (-2.0%) to 98.039% when pulling 29a6270 on expedite:is-authenticating into cfd11c7 on mjrussell:master.

@coveralls
Copy link

coveralls commented May 3, 2016

Coverage Status

Coverage decreased (-2.0%) to 98.039% when pulling 3197cfb on expedite:is-authenticating into cfd11c7 on mjrussell:master.

@coveralls
Copy link

coveralls commented May 3, 2016

Coverage Status

Coverage remained the same at 100.0% when pulling 148a87b on expedite:is-authenticating into cfd11c7 on mjrussell:master.

@coveralls
Copy link

coveralls commented May 3, 2016

Coverage Status

Coverage remained the same at 100.0% when pulling 7124532 on expedite:is-authenticating into cfd11c7 on mjrussell:master.

@mjrussell
Copy link
Owner

@cab Thanks this is exactly what I had in mind! Could we extend your test to verify that a custom component is actually rendered in the isLoading branch?

Should be able to use something like this to just check if the LoadingComponent is rendered in the DOM. And we can use the override for the LoadingComponent option

@cab
Copy link
Contributor Author

cab commented May 3, 2016

Glad to hear that! And yeah, sure thing!

@coveralls
Copy link

coveralls commented May 3, 2016

Coverage Status

Coverage remained the same at 100.0% when pulling c8820a7 on expedite:is-authenticating into cfd11c7 on mjrussell:master.

@mjrussell mjrussell merged commit 5740b8e into mjrussell:master May 3, 2016
@mjrussell
Copy link
Owner

Released with Version 0.5.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants