Remove support for Python 2 #474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohnVillalovos
force-pushed
the
jlvillal/remove_old_python
branch
2 times, most recently
from
85a7631
to
60a2463
Compare
NicolasLM
reviewed
Jun 17, 2022
|
I guess future imports should also be removed like |
Will do. Thanks. Should push an update soon. |
JohnVillalovos
force-pushed
the
jlvillal/remove_old_python
branch
4 times, most recently
from
59d635e
to
9c50200
Compare
mjs
approved these changes
Jun 20, 2022
| @@ -102,13 +102,6 @@ When constructing a custom context it is usually best to start with | |||
| the default context, created by the ``ssl`` module, and modify it to | |||
| suit your needs. | |||
|
|
|||
| .. warning:: | |||
Python 2.7 (the last Python 2 release) was End-Of-Life on 1-Jan-2020. * Add requirement to `setup.py` for python_requires=">=3.4.0" * Remove all usage of the `six` library * Remove declared support for Python 2 * Update tox.ini to remove `py27` environment * Update Github workflows to no longer test against Python 2.7 * Remove `from __future__ import print_function` * Remove `from __future__ unicode_literals` * Update tests to import `unittest` and `unittest.mock` directly Closes: mjs#401
JohnVillalovos
force-pushed
the
jlvillal/remove_old_python
branch
from
9c50200
to
6e6ec34
Compare
Thanks! |
|
All good, merged. Thanks! |
mjs
added
semver-major
breaking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python 2.7 (the last Python 2 release) was End-Of-Life on 1-Jan-2020.
Add requirement to setup.py for Python 3.4 or greater
sixlibrarypy27environmentfrom __future__ import print_functionfrom __future__ unicode_literalsunittestandunittest.mockdirectlyCloses: #401