Dhcp discover bsd and centos7 #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alternate format appears in CentOS/RHEL7 as well as some BSD variants such as OS X
psschroeter
force-pushed
the
dhcp-discover-bsd-and-centos7
branch
from
0b0e111
to
349cb7f
Compare
|
Urgh, yeah, that code is pretty brittle, thanks for making it less so on other/modern platforms! Should replace it with a call to the macaddr gem really, but this will Do For Now ™️ 👍 |
|
Included in release 1.3.2. |
|
Awesome, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to get the mac address embedded in the packet correctly for CentOS and RHEL 7. This also covers OS X and should cover FreeBSD as a bonus as well.