fix(appconfig): middyjs#1009 fix bug when configuration is returned a…

…s empty array
mju-spyrosoft · Mar 16, 2023 · 77ac83c · 77ac83c
1 parent 9f898a4
commit 77ac83c
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/packages/appconfig/__tests__/index.js b/packages/appconfig/__tests__/index.js
@@ -58,9 +58,9 @@ test.serial(
           cacheExpiry: 0,
           fetchData: {
             key: {
-              ApplicationIdentifier: 'xb0nby2',
-              ConfigurationProfileIdentifier: 'ofexqm2',
-              EnvironmentIdentifier: '7tp0goq'
+              ApplicationIdentifier: '...',
+              ConfigurationProfileIdentifier: '...',
+              EnvironmentIdentifier: '...'
             }
           }
         })
@@ -127,7 +127,7 @@ test.serial(
 )
 
 test.serial(
-  'It should keep previous configuration value if getLatestConfiguration returns null configuration',
+  'It should keep previous configuration value if getLatestConfiguration returns empty configuration array',
   async (t) => {
     mockClient(AppConfigDataClient)
       .on(StartConfigurationSessionCommand)
@@ -148,7 +148,7 @@ test.serial(
       })
       .resolvesOnce({
         ContentType: 'application/json',
-        Configuration: null,
+        Configuration: strToUintArray(''),
         NextPollConfigurationToken: 'NextConfigToken'
       })
 

diff --git a/packages/appconfig/index.js b/packages/appconfig/index.js
@@ -45,7 +45,7 @@ const appConfigMiddleware = (opts = {}) => {
         configurationTokenCache[internalKey] =
           configResp.NextPollConfigurationToken
 
-        if (configResp.Configuration == null) {
+        if (configResp.Configuration.length === 0) {
           return configurationCache[internalKey]
         }