-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migration to POI 4.0.1 #81
Conversation
… First pomegranate removed that feature, then dynapath... https://github.com/tobias/dynapath#note-on-urlclassloader https://github.com/cemerick/pomegranate#urlclassloader-modifiability
resolving #78 |
I was looking for something like this. Thanks. I quickly reviewed it and it seems to be just a case of fixing references to enums due to the underlying library refactoring things. Seems simple enough. I did some research and the https://bz.apache.org/bugzilla/show_bug.cgi?id=60713 I will test this in my company project and hopefully get back to see how 4.1.0 POI fares. |
Just tried this patch out with POI 4.1.0 and still seems good. (miikka@2e0ade9) |
Update POI to 4.1.0 and added a deps.edn file
Thank you for your valuable contribution. I have added you to the contributor list. |
Thank you so much for this @manuelherzog and everyone involved, you are amazing! The --illegal-access=warn warning has been annoying me for months and now my tests run sparkly clean. :D |
Hey,
right now i'm doing the migration, as i need the newer version for other POI tasks and libs.
I'm getting to multiple problems before i could start, lein test did not run because the Classloader was not found. I updated pomegranate and then get the error that there is no writeable Classloader anymore. Then i removed that one test that was failing because it can't add the test-data to the classpath.
I upgraded to POI 4.0.1 and it works quite easily.
But, now i get the exception "Truncated ZIP file" on one test only. Rolled back and noticed that the stream that was written to was not closed properly.
Sending you the pull request with 3 commits, if you want to fix the two problems not directly attached to the migration in another way
Best
Manuel