Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration to POI 4.0.1 #81

Merged
merged 7 commits into from
Jun 17, 2020
Merged

Migration to POI 4.0.1 #81

merged 7 commits into from
Jun 17, 2020

Conversation

manuelherzog
Copy link
Contributor

Hey,

right now i'm doing the migration, as i need the newer version for other POI tasks and libs.

I'm getting to multiple problems before i could start, lein test did not run because the Classloader was not found. I updated pomegranate and then get the error that there is no writeable Classloader anymore. Then i removed that one test that was failing because it can't add the test-data to the classpath.

I upgraded to POI 4.0.1 and it works quite easily.

But, now i get the exception "Truncated ZIP file" on one test only. Rolled back and noticed that the stream that was written to was not closed properly.

Sending you the pull request with 3 commits, if you want to fix the two problems not directly attached to the migration in another way

Best
Manuel

@manuelherzog
Copy link
Contributor Author

resolving #78

@raymond-w-ko
Copy link

I was looking for something like this. Thanks.

I quickly reviewed it and it seems to be just a case of fixing references to enums due to the underlying library refactoring things. Seems simple enough.

I did some research and the .close is now necessary due to a decision they made to not auto close the stream on workbook write so you can write multiple workbooks. Details in the link below:

https://bz.apache.org/bugzilla/show_bug.cgi?id=60713

I will test this in my company project and hopefully get back to see how 4.1.0 POI fares.

@miikka
Copy link

miikka commented Oct 8, 2019

Just tried this patch out with POI 4.1.0 and still seems good. (miikka@2e0ade9)

@vemv vemv mentioned this pull request Oct 30, 2019
@mjul mjul merged commit 2f15240 into mjul:master Jun 17, 2020
@mjul
Copy link
Owner

mjul commented Jun 17, 2020

Thank you for your valuable contribution. I have added you to the contributor list.

@rutchkiwi
Copy link

Thank you so much for this @manuelherzog and everyone involved, you are amazing! The --illegal-access=warn warning has been annoying me for months and now my tests run sparkly clean. :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants