Fixed infinite loop in sn_coap_parser_options_parse_multiple_options() #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed the issue with improved boundary checks and inproved end-of multiple options processing loop break conditions. Simplified the sn_coap_parser_options_count_needed_memory_multiple_option() function by reusing extended options number/length parsing functions. Removed the need for one being one byte behind the actual option value in case of multiple options processing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issuue ARMmbed/mbed-os#12929 fixed with improved boundary checks and correct end-of multiple options processing loop break conditions.
Simplified the sn_coap_parser_options_count_needed_memory_multiple_option() function by reusing extended options number/length parsing functions.
Removed the need for one being one byte behind the actual option value in case of multiple options processing.