Improve tree placement #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Old behavior: Choose a single best placement, then fail if expansion constraints prove infeasible. New behavior: Try best placement. If infeasible, backtrack and try next best.
The `listAllPossibleTreePlacements()` methods no longer take any `HolaOpts` into account.
Having `listAllPossibleTreePlacements()` now return ordinal placements, even when cardinal placements are preferred, results in some necessary adjustments to our tests. In the case of `nudgeopt.cpp`, the adjustment is due to instability in the sorting methods employed at the start of the `chooseBestPlacement()` function. `S` placement is now chosen instead of `W`, due to arbitrary ordering.
Seems that certain outcomes may differ, depending on the test runner. Maybe a consequence of differences in RNG?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves the tree placement phase of the HOLA algorithm.
Old behavior: Choose a single best placement, then fail if expansion constraints prove infeasible.
New behavior: Try best placement. If infeasible, backtrack and try next best.