Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes in spatialreg and splm impact strm #34

Closed
rsbivand opened this issue Mar 16, 2021 · 3 comments
Closed

Changes in spatialreg and splm impact strm #34

rsbivand opened this issue Mar 16, 2021 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@rsbivand
Copy link

Because spatialreg is diverging from spdep, and because model-fitting functions in spdep will soon be defunct, the names of model output classes have been changed, and many S3 methods are no longer exported from the spatialreg NAMESPACE. Please install: remotes::install_github("r-spatial/spatialreg") and try to install splm from R-Forge (revision 227); I get the following check log with these:
00check.log.
You will need to work around the lag in broom not yet having a tidy method for the renamed sarlm class from spdep, now Sarlm in spatialreg. The coefficient table will be re-arranged anyway, so the spdep/sarlm tidy method will not work for the spatialreg version. Splitting out modelling functions was intended to make it easier to develop these faster, leaving spdep with neighbour object creation and tests for spatial autocorrelation.

@mkamenet3 mkamenet3 added the bug Something isn't working label Mar 16, 2021
@mkamenet3 mkamenet3 self-assigned this Mar 16, 2021
mkamenet3 added a commit that referenced this issue Mar 22, 2021
@mkamenet3
Copy link
Owner

Hello and thank you for letting me know. I got around the broom dependency with gt and updated the requirements. The vignettes in the GitHub version should work now. Looking forward to continue exploring the new spatialreg.

@rsbivand
Copy link
Author

rsbivand commented May 3, 2021

The 1.1-8 version of spatialreg will be on CRAN shortly, so you will need to submit your fixed package soon. Thanks for being pro-active and handling this straight away.

@mkamenet3
Copy link
Owner

Thank you for letting me know - I'll submit the fix to CRAN shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants