Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support all available Prism grammars and use prism autoloader plugin to dynamically load grammars on page #15

Closed
wants to merge 3 commits into from

Conversation

jazanne
Copy link
Contributor

@jazanne jazanne commented Sep 22, 2018

Dynamically loads languages that are required on the page with the Prims Autoloader plugin.

Adds support for all Prism 1.1.5.0 grammars

(Ref: #2, #14)

@jazanne jazanne changed the title Uses prism autoloader plugin to dynamically load grammars on page Support all available Prism grammars and use prism autoloader plugin to dynamically load grammars on page Sep 23, 2018
@mkaz
Copy link
Owner

mkaz commented Oct 11, 2018

I need to look further at this PR, overall it looks good. However, the style changes on the front-end of my site when I apply it, when I expect it to be the same before/after the PR.

My hunch is my default style theme, which is the Github-like colors, is different than the Prism default.

@jazanne
Copy link
Contributor Author

jazanne commented Oct 19, 2018

Oh good point, I didn't really realize it was a different theme when I downloaded from Prism website. I'm happy to revert the css changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants