Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: login.py MFA form id updated #128

Merged
merged 3 commits into from
Sep 4, 2023
Merged

fix: login.py MFA form id updated #128

merged 3 commits into from
Sep 4, 2023

Conversation

Humni
Copy link
Contributor

@Humni Humni commented Sep 3, 2023

Resolves #127

@Humni Humni mentioned this pull request Sep 3, 2023
Closed
@mkb79 mkb79 self-requested a review September 3, 2023 10:27
@mkb79
Copy link
Owner

mkb79 commented Sep 3, 2023

Replacing auth-mfa-form with verification-code-form could raise another issue. I'll think at the app should check for both?!

@Humni
Copy link
Contributor Author

Humni commented Sep 4, 2023

@mkb79 Yes that's true, I'm not sure if it's a new page or a different one that the OTP is appearing on. It would be safer to check for both (especially if it's account settings or region specific). I'll update the PR

mkb79
mkb79 approved these changes Sep 4, 2023
View reviewed changes
Copy link
Owner

@mkb79 mkb79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for me.

@mkb79 mkb79 merged commit b4dcadc into mkb79:master Sep 4, 2023
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkb79 mkb79 mkb79 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Amazon authentication code not handled properly
2 participants
@Humni @mkb79